Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MyMonitor: doesn't support showing NT/U21 last/next match #1712

Open
dominiquelee opened this issue Aug 13, 2023 · 2 comments
Open

MyMonitor: doesn't support showing NT/U21 last/next match #1712

dominiquelee opened this issue Aug 13, 2023 · 2 comments

Comments

@dominiquelee
Copy link
Contributor

MyMonitor cannot display matches for NT and U21 teams:
image

See

/** @type {CHPPParams} */
var args = [
['file', 'matches'],
['version', '2.8'],
['teamId', Number(team.id)],
];

NT matches should most likely be retrieved from nationalteammatches (which does not take a teamId parameter, only whether we want NT or U21 matches) and filtered from there. Ideally, only one call is made even if multiple NT teams are tracked in MyMonitor (and no call at all if there is none).
Please note that team.type in this function is currently equal to nt for both NT and U21 teams, so extra parsing is needed.

@minj
Copy link
Owner

minj commented Aug 13, 2023

Sure, feel free to submit a PR

@murko69
Copy link
Contributor

murko69 commented Oct 2, 2023

Side note for anyone feeling up to fix that NT-issue.

There is a counter on the team page telling how many teams are added to MyMonitor
1-monitor-team

I'd like that also on the MyMonitor page itself at the top somewhere like:
2-monitor-main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants