Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App completed #1

Open
minhkhang1795 opened this issue Mar 28, 2016 · 1 comment
Open

App completed #1

minhkhang1795 opened this issue Mar 28, 2016 · 1 comment

Comments

@minhkhang1795
Copy link
Owner

My app is complete. Please review. /cc @hoanle @coderschoolreview

I don't know why my offline tweets are limited to 1-4 tweets and they still remain the same for hours (although new online tweets were created while I was doing this)

@hoanle
Copy link

hoanle commented Mar 28, 2016

@vuminhkhang1995

👍 Great work. A few notes after checking out the code:

  • Good to see you were able to format the timestamp cleanly
  • Nice to see you used the SwipeRefreshLayout for easy timeline refreshes
  • Good to see you added the tweet to the home timeline after you posted new on compose
  • Nice touch with the character count being displayed while the user composes a tweet
  • Glad to see you made the compose activity into a dialog instead
  • Good to see you added ActiveAndroid annotations to the models
  • Good to see you added ActiveAndroid annotations to the models
  • Reply does not work. Is it just composing a new Tweet?
  • Storing database to local does not work correctly. Only 1 record display when re-activate the internet and pull to refresh the list. The list also display wrong order
  • setRelativeTimeAgo in adapter should be elsewhere, same with isOnline. Put them in some Util class to use globally
  • You have used ButterKnife, it not only provide Bind but also provide OnClick and other annotation. Use them
  • Why not use Gson or Jackson?

Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants