Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test of mindsdb commands #337

Closed
ea-rus opened this issue Dec 29, 2023 · 0 comments · Fixed by #354
Closed

Improve test of mindsdb commands #337

ea-rus opened this issue Dec 29, 2023 · 0 comments · Fixed by #354
Assignees
Labels
enhancement New feature or request

Comments

@ea-rus
Copy link
Contributor

ea-rus commented Dec 29, 2023

Create test which:

  • import all tests from 'test_mindsdb' folder
  • replace parse_sql function to add block:
    • convert AST to_string and parse it again
    • compare result from first and second parsing

It will help to find (and prevent) cases when render function returns output which can't be parsed

@tomhuds tomhuds added the enhancement New feature or request label Jan 8, 2024
ea-rus added a commit that referenced this issue Feb 22, 2024
@ea-rus ea-rus mentioned this issue Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants