Error in minibuffer-exit-hook (vertico-buffer--restore): (error "Attempt to delete minibuffer or sole ordinary window")

[hab25]

Environment: emacs 29.3, vertico 1.8, consult 1.7

Reproduce with emacs -Q:

1. evaluate

(progn
  (require 'consult)
  (require 'vertico-buffer)
  (require 'vertico-multiform)
  (setopt vertico-multiform-commands
   	  `((,#'consult-ripgrep
   	     .
   	     (buffer
	      ;; works nicely with consult preview when `read-minibuffer-restore-windows` is `t` (the default)
   	      (vertico-buffer-display-action ,#'display-buffer-full-frame)))))
  (vertico-mode)
  (vertico-multiform-mode)
  (select-window (display-buffer-in-side-window (get-buffer "*Messages*") nil)))

2. type M-x -> "consult-ripgrep" -> RET (make sure the *Messages* buffer is selected in the side window, which should be the state the code ended at)
3. quit out immediately (i.e. without typing anything else) by typing ESC ESC ESC
4. note the message Error in minibuffer-exit-hook (vertico-buffer--restore): (error "Attempt to delete minibuffer or sole ordinary window") in the *Messages* buffer

Optionally,

5. repeat step 2
6. type a string that does match something your home directory, perhaps "bash", and then quit by doing ESC ESC ESC
7. observe that no new (i.e. from step 5 onwards) error message appeared in the *Messages* buffer

[minad]

Hi, I have difficulties reproducing this problem on Emacs 30. Can you please check if the problem is still present there? (FWIW I consider vertico-buffer-display-action=display-buffer-full-frame with consult-ripgrep a misconfiguration, since the Consult preview will split the frame anyway).

[minad]

That's odd. I don't see the error message when trying this. Maybe it would help to add an additional check here:

vertico/extensions/vertico-buffer.el

Lines 183 to 184 in ba650a7

	((window-live-p win)
	(delete-window win)))

[hab25]

That's odd. I don't see the error message when trying this. Maybe it would help to add an additional check here:

vertico/extensions/vertico-buffer.el

Lines 183 to 184 in ba650a7

	((window-live-p win)
	(delete-window win)))

Given that nothing seems to be broken if one disregards the error message, that might be correct.

Just in case it helps with brainstorming the solution, note again that if one tries to initiate consult-ripgrep from a regular window (i.e. non-side), the error doesn't occur.

[minad]

Just in case it helps with brainstorming the solution, note again that if one tries to initiate consult-ripgrep from a regular window (i.e. non-side), the error doesn't occur.

Ah, I probably missed that when reproducing it. Sorry I've over read that above.

[minad]

Let's go with the simple fix for now: 0d2cde6

Please let me know if this still breaks in some circumstances.

[hab25]

Let's go with the simple fix for now: 0d2cde6

Please let me know if this still breaks in some circumstances.

Thank you; I will.

[nerffan1]

Let's go with the simple fix for now: 0d2cde6

Please let me know if this still breaks in some circumstances.

Sorry to bother you, I am using doom emacs, so I am not sure if I should go to someone else or to this repo. I am using special characters with different encoding and I am unable to delete the vertico minibuffer when I try to choose a different type of encoding:

I am not able to delete this and I have to close all of emacs to get rid of this. Any ideas what I can do?