Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize should take []byte for remote keys #33

Open
mimoo opened this issue Oct 16, 2018 · 0 comments
Open

Initialize should take []byte for remote keys #33

mimoo opened this issue Oct 16, 2018 · 0 comments
Labels
enhancement

Comments

@mimoo
Copy link
Owner

mimoo commented Oct 16, 2018

Here's Initialize():

func Initialize(handshakeType noiseHandshakeType, initiator bool, prologue []byte, s, e, rs, re *KeyPair)

It doesn't make sense to take *KeyPair for rs and re. We should just accept []byte (which can be set to nil as well).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mimoo