Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings of clashes with Clojure 1.11.0 abs. #357

Open
wedesoft opened this issue Mar 23, 2022 · 6 comments
Open

Warnings of clashes with Clojure 1.11.0 abs. #357

wedesoft opened this issue Mar 23, 2022 · 6 comments
Labels

Comments

@wedesoft
Copy link

wedesoft commented Mar 23, 2022

Clojure 1.11.0 and core.matrix both define abs leading to clashes. One gets a couple of warnings when requiring clojure.core.math clojure.core.matrix. Maybe abs should be renamed to mabs?

@mikera
Copy link
Owner

mikera commented Mar 23, 2022

I think best practice is for users to specify which symbols they import (with e.g. :refer) or even better use an alias? I think we are unlikely to rename core.matrix key functions at this point (there are plenty of other clashes with other library namespaces etc. this is unavoidable due to Clojure's design and the recommendation to use the best names in each namespace.

@wedesoft
Copy link
Author

Ok, I agree. But even when using :refer one gets warnings, because there are some clashes with abs inside clojure.core.matrix.

@wedesoft
Copy link
Author

Maybe unlike sin, cos, ... which are in clojure.core.math, abs is now in Clojure's main namespace I believe.

@wedesoft
Copy link
Author

I meant to say, one gets this warnings when requiring clojure.core.matrix even when using :refer.

@wedesoft
Copy link
Author

Thanks for developing core.matrix btw. Really useful software! 👍

@jumarko
Copy link

jumarko commented Dec 21, 2022

I second this - it would be great to get rid of those warnings.
Several other libraries have fixed similar problems after clojure 1.11 was released, e.g. here MastodonC/kixi.stats#41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants