Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what is the purpose of 'unimplemented' function in utils #349

Open
irfn opened this issue May 18, 2021 · 2 comments
Open

what is the purpose of 'unimplemented' function in utils #349

irfn opened this issue May 18, 2021 · 2 comments

Comments

@irfn
Copy link
Contributor

irfn commented May 18, 2021

I don't see usages of unimplemented function anywhere in the codebase.
src/main/clojure/clojure/core/matrix/utils.cljc
If there is no specific use, I would suggest removing this method.

The reason I ask is that this method adds a clojure.reflect dependency that I would like to avoid as I am trying to use core.matrix using https://github.com/borkdude/sci which is a lightweight interpreter.

@mikera
Copy link
Owner

mikera commented May 18, 2021

Happy to take a PR to remove this. It was mostly useful during early development, when a lot of code paths needed to be completed.

@irfn
Copy link
Contributor Author

irfn commented May 19, 2021

will send a PR. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants