prepend "XDG_RUNTIME_DIR" to command method in order to fix #226 #307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #226 some people complained that node-notifier doesnt work if the script is automatically invoked by CRON.
SPDUK however found a soloution which is to prepend
XDG_RUNTIME_DIR=/run/user/$(id -u)
to the command, i think we should modify the way
node-notifier
calls the notify-send function so it just works out of the box.I cant check whether this is working cross platform, on Linux it works like a charm, other platforms have to be tested, i dont have any windows/mac machine here so i unforunately cant test it :/