Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepend "XDG_RUNTIME_DIR" to command method in order to fix #226 #307

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chatn0ir07
Copy link

In #226 some people complained that node-notifier doesnt work if the script is automatically invoked by CRON.
SPDUK however found a soloution which is to prepend
XDG_RUNTIME_DIR=/run/user/$(id -u)
to the command, i think we should modify the way node-notifier calls the notify-send function so it just works out of the box.

I cant check whether this is working cross platform, on Linux it works like a charm, other platforms have to be tested, i dont have any windows/mac machine here so i unforunately cant test it :/

@mikaelbr
Copy link
Owner

mikaelbr commented Apr 8, 2020

This looks to me to be very Unix specific. I have some concerns if this is something this module should handle or not, but in any case the PR as it sits now seems to add the envvar to every command also on mac and windows, which looks from #226 like it is unnecessary? If anywhere, maybe this should be inside notify-send implementation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants