Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate Endpoint rather than sleeping and praying #28

Open
jmontleon opened this issue Jun 25, 2021 · 1 comment
Open

Validate Endpoint rather than sleeping and praying #28

jmontleon opened this issue Jun 25, 2021 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug. state-lib

Comments

@jmontleon
Copy link
Contributor

probably split this into two methods, CreateEndpoint simply tries to create the service. The other method, ValidateEndpoint checks if the valid status is present? Once the valid status is populated, we can call the r.SetHostname and r.SetPort

Originally posted by @alaypatel07 in #2 (comment)
@jmontleon
Copy link
Contributor Author

jmontleon commented Jun 25, 2021 •
edited
Loading

Alay shared:

you can use a poller, it will be slightly better.

https://github.com/kubernetes/kubernetes/blob/2453f07e933a6d2ac0be1eb35061a2154ccce5b8/test/e2e/framework/util.go#L269

@jmontleon jmontleon added kind/bug Categorizes issue or PR as related to a bug. state-lib labels Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. state-lib
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jmontleon