[Placement Group] Add support for soft anti affinity #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgriddaluru
commented
Nov 20, 2024
bgriddaluru
commented
- Add support for soft anti affinity
- To determine if FC supports SoftAntiAffinity, check if SoftAntiAffinity property is present in Affinity Rule class
- For containers, fix issue where wrong volume is matched due to partial prefix match.
mkatturu
previously approved these changes
Nov 23, 2024
piyushka17
requested changes
Nov 23, 2024
| @@ -97,3 +98,45 @@ func GetAffinityRule(whost *host.WmiHost, affinityRuleName string) (caffinityRul | |||
| caffinityRule = &AffinityRule{wmiafRule} | |||
| return | |||
| } | |||
|
|
|||
| // SetAffinityRule updates an existing affinity rule | |||
There was a problem hiding this comment.
you couldn't merge it in existing 'CreateAffinityRule' method (rather than creating another function)?
There was a problem hiding this comment.
Just to be consistent with current code, added a simple wrapper on WMI method and have specific logic in moc-pkg layer. I will update as suggested
| return | ||
| } | ||
|
|
||
| softAntiAffinitySupported := false |
There was a problem hiding this comment.
do this only for rule=anti-affinity, softAntiAffinity=true?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.