Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backward-cpp]Update version #35583

Merged
merged 12 commits into from
Dec 28, 2023
Merged

Conversation

endingly
Copy link
Contributor

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Fix complier error on mingw plateform

@endingly endingly changed the title Update backward version [backward-cpp]Update version Dec 10, 2023
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIU the package has dependencies on other libs, and some are provided by vcpkg ports. It would be good to ensure that no dependency accidentally becomes an undeclared artifact dependency.

ports/backward-cpp/vcpkg.json Outdated Show resolved Hide resolved
ports/backward-cpp/portfile.cmake Show resolved Hide resolved
ports/backward-cpp/portfile.cmake Outdated Show resolved Hide resolved
@endingly endingly marked this pull request as draft December 10, 2023 14:42
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Dec 11, 2023
@dg0yt
Copy link
Contributor

dg0yt commented Dec 11, 2023

They install an unusual CMake config file, probably for header-only usage. Some patterns are really strange.
vcpkg's usage heuristics doesn't work well for them. I suggest installing a share/backward-cpp/usage file:

backward-cpp provides CMake targets:

  find_package(Backward CONFIG REQUIRED)
  # To use the header library
  target_link_libraries(main PRIVATE Backward::Interface)
  # To use the prebuilt library
  target_link_libraries(main PRIVATE Backward::Backward)

(untested)

@JonLiu1993 JonLiu1993 added the depends:upstream-changes Waiting on a change to the upstream project label Dec 11, 2023
@endingly
Copy link
Contributor Author

Actually, prior to this PR, Backward had always joined the build system in the form of header only. However, in the current PR, it is added to the compilation in the form of a library.

@endingly endingly marked this pull request as ready for review December 28, 2023 01:42
@endingly
Copy link
Contributor Author

now, add version-date format and a usage file

@JonLiu1993
Copy link
Member

Usage tested successfully by backward-cpp:x64-windows:

backward-cpp provides CMake targets:

  find_package(Backward CONFIG REQUIRED)
  # To use the header library
  target_link_libraries(main PRIVATE Backward::Interface)
  # To use the prebuilt library
  target_link_libraries(main PRIVATE Backward::Backward)

@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed depends:upstream-changes Waiting on a change to the upstream project labels Dec 28, 2023
@vicroms vicroms merged commit eaee229 into microsoft:master Dec 28, 2023
15 checks passed
@endingly endingly deleted the update_version_backward branch December 28, 2023 10:57
Osyotr pushed a commit to Osyotr/vcpkg that referenced this pull request Jan 23, 2024
* update backward-cpp version

* update vcpkg versions json file

* delete `include-dir.diff`

* update vcpkg versions file

* remove PACKAGE_NAME item

* fix version file

* version format changes

* add new version to vcpkg

* add usage

* chage main version in vcpkg

* Add blank line

* update version

---------

Co-authored-by: vzhli17 <v-zhli17@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants