From 922b3560177961affbf4b34852c563e54b00ff49 Mon Sep 17 00:00:00 2001 From: Freddy Kristiansen Date: Wed, 27 Nov 2024 11:40:44 +0100 Subject: [PATCH] fix ps5 issue in Push-BcNuGetPackage (#3769) Co-authored-by: freddydk --- NuGet/NuGetFeedClass.ps1 | 9 +++++---- ReleaseNotes.txt | 1 + 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/NuGet/NuGetFeedClass.ps1 b/NuGet/NuGetFeedClass.ps1 index 612ae9878..0ec6d6e52 100644 --- a/NuGet/NuGetFeedClass.ps1 +++ b/NuGet/NuGetFeedClass.ps1 @@ -357,11 +357,12 @@ class NuGetFeed { $LF = "`r`n"; $tmpFile = Join-Path ([System.IO.Path]::GetTempPath()) ([GUID]::NewGuid().ToString()) $fs = [System.IO.File]::OpenWrite($tmpFile) + $fs | Add-Member -MemberType ScriptMethod -Name WriteBytes -Value { param($bytes) $this.Write($bytes, 0, $bytes.Length) } try { - $fs.Write([System.Text.Encoding]::UTF8.GetBytes("--$boundary$LF")) - $fs.Write([System.Text.Encoding]::UTF8.GetBytes("Content-Type: application/octet-stream$($LF)Content-Disposition: form-data; name=package; filename=""$([System.IO.Path]::GetFileName($package))""$($LF)$($LF)")) - $fs.Write([System.IO.File]::ReadAllBytes($package)) - $fs.Write([System.Text.Encoding]::UTF8.GetBytes("$LF--$boundary--$LF")) + $fs.WriteBytes([System.Text.Encoding]::UTF8.GetBytes("--$boundary$LF")) + $fs.WriteBytes([System.Text.Encoding]::UTF8.GetBytes("Content-Type: application/octet-stream$($LF)Content-Disposition: form-data; name=package; filename=""$([System.IO.Path]::GetFileName($package))""$($LF)$($LF)")) + $fs.WriteBytes([System.IO.File]::ReadAllBytes($package)) + $fs.WriteBytes([System.Text.Encoding]::UTF8.GetBytes("$LF--$boundary--$LF")) } finally { $fs.Close() } diff --git a/ReleaseNotes.txt b/ReleaseNotes.txt index cb5c334f4..f156537e9 100644 --- a/ReleaseNotes.txt +++ b/ReleaseNotes.txt @@ -2,6 +2,7 @@ Issue 3762 Give Option to Choose SQL PowerShell Module When Restoring From BacPac There are instances where sqlps does not work as expected when it is installed. This change adds a switch parameter, useSqlServerModule, to Restore-BcDatabaseFromArtifacts, New-NavContainer, and the BcContainerHelper config file. Issue 1303 from AL-Go repository - renew federated token when access token needs renewal (works only for GitHub at this time) +Regression when from PR 3760 - Push-BcNuGetPackage doesn't work on PowerSHell 5 6.0.29 Issue 3591 When using Publish-NAVApp to publish an app, which fails compilation in the service, the command might hang forever - the fix for this is a temporary hack put in place for the versions which doesn't work.