Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sleep between VM stop and start for restart command #293

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add sleep between VM stop and start for restart command #293

wants to merge 2 commits into from

Conversation

ganeshamohana
Copy link
Contributor

@ganeshamohana ganeshamohana commented Nov 8, 2024 •
edited
Loading

@ganeshamohana
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

nikohobart
nikohobart approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@nikohobart nikohobart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but 5 seconds seems like a lot for merging into prod, I guess it's a temporary necessity for successful restart cmds?

Would one alternative be to add a check at the "stop" level in nodeagent that confirms the vm has actually stopped? Sorry I'm missing some context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikohobart nikohobart nikohobart approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ganeshamohana @nikohobart