added grpc interceptor and singleton changes #130
Conversation
|
|
||
| //If GetClientOpts called before SetClientOpts, it will return a default ClientOpts | ||
| func GetClientOpts() *ClientOpts { | ||
| once.Do(func() { |
There was a problem hiding this comment.
Wouldn't this cause an issue if set is called before get. The clientOptsSingleton would be nil
There was a problem hiding this comment.
if once.Do(f) is called multiple times, only the first call will invoke f, even if f has a different value in each invocation. A new instance of Once is required for each function to execute.
There was a problem hiding this comment.
So the expected behaviour is to call Set before Get, which the developer needs to ensure. In case if Set is not called and Get is invoked first, the default value of the NoExitOnConnFailure will be set to false as once.Do will execute once and set it once finally. In case Get is called before, the value will not be nil. As the NoExitOnConnFailure flag is set at the beginning of the mocctl process, I am ensuring that for mocctl the Set is being called before any Get operations occur
There was a problem hiding this comment.
Cant we just check if clientOptsSingleton is not nil and return default if nil?
There was a problem hiding this comment.
We can do that as well, but we would need to take care of thread safety explicitly. I used once.Do because it is inherently thread safe. Do you want me to implement the nil checking logic?
…to grpc_exit_pods_issue_fix
…ft/moc-sdk-for-go into grpc_exit_pods_issue_fix
|
@Kaivalya1997 do we still want to pick up this PR? If not, can we close it? |
No description provided.