Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Legacy flag does not get passed through in opensslPkcsArgs argument of the InstallAppleCertificateV2 task #19436

Closed
4 of 7 tasks
darijan-darijan opened this issue Jan 10, 2024 · 7 comments
Labels
Area: ABTT Akvelon Build Tasks Team area of work question Task: InstallAppleCertificate

Comments

@darijan-darijan
Copy link

darijan-darijan commented Jan 10, 2024

New issue checklist

Task name

InstallAppleCertificateV2

Task version

2

Issue Description

What did I do
passed the '-legacy' flag through the opensslPkcsArgs

What did I see

/usr/local/bin/openssl pkcs12 -in ... -nokeys -passin pass:*** | /usr/local/bin/openssl x509 -noout -fingerprint -subject -dates -nameopt utf8,sep_semi_plus_space
Error outputting keys and certificates

The error that was already reported here
#18560

What did I expect to see

I expected to see the '-legacy' flag appended to the command, but looks like it does not get passed. Also I expected the command to be executed successfully on MacOS 13 with the '-legacy' flag

Environment type (Please select at least one enviroment where you face this issue)

  • Self-Hosted
  • Microsoft Hosted
  • VMSS Pool
  • Container

Azure DevOps Server type

dev.azure.com (formerly visualstudio.com)

Azure DevOps Server Version (if applicable)

Agent version: 2.213.2

Operation system

MacOS 13

Relevant log output

/usr/local/bin/openssl pkcs12 -in ... -nokeys -passin pass:*** | /usr/local/bin/openssl x509 -noout -fingerprint -subject -dates -nameopt utf8,sep_semi_plus_space
Error outputting keys and certificates

Full task logs with system.debug enabled

 [REPLACE THIS WITH YOUR INFORMATION] 

Repro steps

- task: InstallAppleCertificate@2
     inputs:
        certSecureFile: '$(certFileName)'
        certPwd: '$(P12password)'
        keychain: 'temp'
        opensslPkcsArgs: '-legacy'
@darijan-darijan darijan-darijan changed the title [BUG]: Legacy flag does not get passed through in opensslPkcsArgs [BUG]: Legacy flag does not get passed through in opensslPkcsArgs argument of the InstallAppleCertificateV2 task Jan 10, 2024
@v-mohithgc v-mohithgc added Area: ABTT Akvelon Build Tasks Team area of work and removed Area: Release labels Jan 10, 2024
@darijan-darijan
Copy link
Author

Can someone help please ?
You have added the -legacy flag and the opensslPkcsArgs argument but you didnt say anything about where is it available ?

Do I need to update the Azure Devops version ?

My current version is Version Azure DevOps Server 2022 (AzureDevOpsServer_20221122.1)

Is it tied to the version, or the agent version ? What is it tied to ?

Which Azure Devops version has this argument available
opensslPkcsArgs

@darijan-darijan
Copy link
Author

Screenshot 2024-01-12 at 3 22 41 PM

I am suspecting it is related to the version of the InstallAppleCertifificate@2 Task.

My current version is 2.200.0

Could you please let me know if this is the reason i cannot use the opensslPkcsArgs parameter ?

@KonstantinTyukalov
Copy link
Contributor

Hi @darijan-darijan, opensslPkcsArgs parameter was introduced in v2.225.0
Could you try updating the task to this or a newer version?

@gucoelho
Copy link

Hi guys, same thing is happening to me:
image

I'm using a Microsoft hosted agent macos-latest

@darijan-darijan
Copy link
Author

Hi guys, same thing is happening to me: image

I'm using a Microsoft hosted agent macos-latest

not the same thing. If you look closely your legacy flag is getting passed
check this issue , it might help
#19383

@gucoelho

@KonstantinTyukalov
Copy link
Contributor

Hello @darijan-darijan, I was wondering if you’ve had a chance to update the task and make sure the issue has been resolved for you? Thank you.

@darijan-darijan
Copy link
Author

darijan-darijan commented Feb 12, 2024

if anyone experiences this issue in the future , make sure that your version of InstallAppleTaskCertificate@2 is up to date. You can find the current version in the pipeline log.

And as for the development team, please next time you change a feature, dont simply say "we have added the flag"
You need to specify the exact version of the task that contains the changes as the version system in Azure devops is quite finnicky.

You have the task @ version (eg. @ 2, @ 3, @ 4)
You have the numerical task version (the one in the pipeline log eg. 2.231.1)
You have the agent version
The Azure devops platform version
The runner image version

There are so many versions and version types to keep track of, its super finnicky, so please be more verbose and descriptive moving forward.

Closing this task, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: ABTT Akvelon Build Tasks Team area of work question Task: InstallAppleCertificate
Projects
None yet
Development

No branches or pull requests

4 participants