-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timeline component and thread-history pattern #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/atlas-design into jamesbe/thread-history
🦋 Changeset detectedLatest commit: 7189d64 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jim-benson
changed the title
Add thread history pattern and styles
Add timeline pattern and styles
Nov 12, 2024
BenDMyers
reviewed
Nov 13, 2024
BenDMyers
reviewed
Nov 13, 2024
wibjorn
reviewed
Nov 13, 2024
wibjorn
reviewed
Nov 13, 2024
wibjorn
reviewed
Nov 13, 2024
wibjorn
reviewed
Nov 13, 2024
wibjorn
reviewed
Nov 13, 2024
wibjorn
reviewed
Nov 13, 2024
wibjorn
reviewed
Nov 13, 2024
wibjorn
reviewed
Nov 13, 2024
BenDMyers
reviewed
Nov 14, 2024
wibjorn
reviewed
Nov 14, 2024
wibjorn
reviewed
Nov 14, 2024
wibjorn
reviewed
Nov 14, 2024
wibjorn
reviewed
Nov 14, 2024
wibjorn
reviewed
Nov 14, 2024
wibjorn
reviewed
Nov 14, 2024
wibjorn
reviewed
Nov 14, 2024
jim-benson
changed the title
Add timeline pattern and styles
Add timeline component and thread-history pattern
Nov 14, 2024
wibjorn
reviewed
Nov 14, 2024
wibjorn
reviewed
Nov 14, 2024
wibjorn
reviewed
Nov 14, 2024
wibjorn
reviewed
Nov 15, 2024
wibjorn
reviewed
Nov 15, 2024
wibjorn
reviewed
Nov 15, 2024
homing1
reviewed
Nov 16, 2024
Co-authored-by: Ming Ho <94572161+homing1@users.noreply.github.com>
wibjorn
reviewed
Nov 18, 2024
…/atlas-design into jamesbe/thread-history
BenDMyers
reviewed
Nov 18, 2024
BenDMyers
reviewed
Nov 18, 2024
Co-authored-by: Ben Myers <benmyers@microsoft.com>
wibjorn
approved these changes
Nov 18, 2024
BenDMyers
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: task-1013232: Add timeline to atlas
Link: preview
This PR aims to add a vertical timeline component that uses the updated badge component and well as introduces the thread history pattern that is used in Q&A.
The styles and structure for the timeline component will be broad enough to be used is other instances of Learn.
Testing
git checkout jamesbe/thread-history; npm start;
Expected result: timelines usage should be clear
Expected result: the thread history pattern should be understandable to implement
Contributor checklist