Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeline component and thread-history pattern #722

Merged
merged 25 commits into from
Nov 18, 2024

Conversation

jim-benson
Copy link
Contributor

@jim-benson jim-benson commented Nov 12, 2024

Task: task-1013232: Add timeline to atlas

Link: preview

This PR aims to add a vertical timeline component that uses the updated badge component and well as introduces the thread history pattern that is used in Q&A.

The styles and structure for the timeline component will be broad enough to be used is other instances of Learn.

Testing

  1. git checkout jamesbe/thread-history; npm start;
  2. Navigate to the timeline component
    Expected result: timelines usage should be clear
  3. Navigate to the thread history pattern
    Expected result: the thread history pattern should be understandable to implement

Contributor checklist

  • Did you update the description of this pull request with a review link and test steps?
  • Did you submit a changeset? Changesets are required for all code changes.
  • Does your pull request implement complex UI logic (js/ts)? Consider adding an integration test to test your user flow.
  • Does your pull request add a new page to the documentation site? Add your new page for automated accessibility testing in /integration/tests/accessibility.

@jim-benson jim-benson requested a review from a team as a code owner November 12, 2024 17:20
Copy link

changeset-bot bot commented Nov 12, 2024

🦋 Changeset detected

Latest commit: 7189d64

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@microsoft/atlas-site Minor
@microsoft/atlas-css Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jim-benson jim-benson changed the title Add thread history pattern and styles Add timeline pattern and styles Nov 12, 2024
integration/config/page.ts Outdated Show resolved Hide resolved
@jim-benson jim-benson changed the title Add timeline pattern and styles Add timeline component and thread-history pattern Nov 14, 2024
Co-authored-by: Ming Ho <94572161+homing1@users.noreply.github.com>
Co-authored-by: Ben Myers <benmyers@microsoft.com>
@jim-benson jim-benson merged commit 3c48da8 into main Nov 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants