Module resolution: NodeNext breaks typechecking #60561
Comments
|
I think we can also assume that as people will switch from tsx-like tools to the native nodejs flag to have typescript, the more we'll see this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Demo Repo
https://github.com/damianobarbati/ts-repro
Which of the following problems are you reporting?
The module specifier resolves to the right file, but something about the types are wrong
Demonstrate the defect described above with a code sample.
To reproduce:
git clone git@github.com:damianobarbati/ts-repro.git cd ts-repro git checkout typescript-constructable-issue pnpm i pnpm tscHere the line where this can be seen:
https://github.com/damianobarbati/ts-repro/blob/typescript-constructable-issue/services/api/src/index.ts#L2
Run
tsc --showConfigand paste its output here{ "compilerOptions": { "moduleResolution": "nodenext", "module": "nodenext", "target": "esnext", "lib": [ "dom", "dom.iterable", "esnext", "webworker" ], "allowJs": true, "allowImportingTsExtensions": true, "skipLibCheck": true, "strict": true, "forceConsistentCasingInFileNames": true, "noEmit": true, "noUnusedLocals": false, "esModuleInterop": true, "resolveJsonModule": true, "strictPropertyInitialization": false, "isolatedModules": true, "jsx": "preserve", "incremental": true, "baseUrl": "./", "tsBuildInfoFile": "../../../../tmp/tsbuildinfo", "moduleDetection": "force", "allowSyntheticDefaultImports": true, "resolvePackageJsonExports": true, "resolvePackageJsonImports": true, "preserveConstEnums": true, "useDefineForClassFields": true, "noImplicitAny": true, "noImplicitThis": true, "strictNullChecks": true, "strictFunctionTypes": true, "strictBindCallApply": true, "strictBuiltinIteratorReturn": true, "alwaysStrict": true, "useUnknownInCatchVariables": true }, "files": [ "./services/api/src/Foe.spec.ts", "./services/api/src/Foe.ts", "./services/api/src/index.ts", "./services/api/src/helper/fn.spec.ts", "./services/api/src/helper/fn.ts", "./services/types/src/User.spec.ts", "./services/types/src/User.ts" ] }Run
tsc --traceResolutionand paste its output herePaste the
package.jsonof the importing module, if it exists{ "name": "api", "type": "module", "imports": { "#api/*": "./src/*", "#api/helper/*": "./src/helper/*" }, "scripts": { "test": "vitest run", "start:dev": "node --no-warnings --experimental-transform-types --watch ./src/index.ts", "start": "node --no-warnings --experimental-transform-types ./src/index.ts" }, "dependencies": { "ioredis": "^5.4.1", "types": "workspace:^" } }Paste the
package.jsonof the target module, if it exists{ "name": "ioredis", "version": "5.4.1", "description": "A robust, performance-focused and full-featured Redis client for Node.js.", "main": "./built/index.js", "types": "./built/index.d.ts", "files": [ "built/" ], "scripts": { "test:tsd": "npm run build && tsd", "test:js": "TS_NODE_TRANSPILE_ONLY=true NODE_ENV=test mocha \"test/helpers/*.ts\" \"test/unit/**/*.ts\" \"test/functional/**/*.ts\"", "test:cov": "nyc npm run test:js", "test:js:cluster": "TS_NODE_TRANSPILE_ONLY=true NODE_ENV=test mocha \"test/cluster/**/*.ts\"", "test": "npm run test:js && npm run test:tsd", "lint": "eslint --ext .js,.ts ./lib", "docs": "npx typedoc --logLevel Error --excludeExternals --excludeProtected --excludePrivate --readme none lib/index.ts", "format": "prettier --write \"{,!(node_modules)/**/}*.{js,ts}\"", "format-check": "prettier --check \"{,!(node_modules)/**/}*.{js,ts}\"", "build": "rm -rf built && tsc", "prepublishOnly": "npm run build", "semantic-release": "semantic-release" }, "repository": { "type": "git", "url": "git://github.com/luin/ioredis.git" }, "keywords": [ "redis", "cluster", "sentinel", "pipelining" ], "tsd": { "directory": "test/typing" }, "author": "Zihua Li <i@zihua.li> (http://zihua.li)", "license": "MIT", "funding": { "type": "opencollective", "url": "https://opencollective.com/ioredis" }, "dependencies": { "@ioredis/commands": "^1.1.1", "cluster-key-slot": "^1.1.0", "debug": "^4.3.4", "denque": "^2.1.0", "lodash.defaults": "^4.2.0", "lodash.isarguments": "^3.1.0", "redis-errors": "^1.2.0", "redis-parser": "^3.0.0", "standard-as-callback": "^2.1.0" }, "devDependencies": { "@ioredis/interface-generator": "^1.3.0", "@semantic-release/changelog": "^6.0.1", "@semantic-release/commit-analyzer": "^9.0.2", "@semantic-release/git": "^10.0.1", "@types/chai": "^4.3.0", "@types/chai-as-promised": "^7.1.5", "@types/debug": "^4.1.5", "@types/lodash.defaults": "^4.2.7", "@types/lodash.isarguments": "^3.1.7", "@types/mocha": "^9.1.0", "@types/node": "^14.18.12", "@types/redis-errors": "^1.2.1", "@types/sinon": "^10.0.11", "@typescript-eslint/eslint-plugin": "^5.48.1", "@typescript-eslint/parser": "^5.48.1", "chai": "^4.3.6", "chai-as-promised": "^7.1.1", "eslint": "^8.31.0", "eslint-config-prettier": "^8.6.0", "mocha": "^9.2.1", "nyc": "^15.1.0", "prettier": "^2.6.1", "semantic-release": "^19.0.2", "server-destroy": "^1.0.1", "sinon": "^13.0.1", "ts-node": "^10.4.0", "tsd": "^0.19.1", "typedoc": "^0.22.18", "typescript": "^4.6.3", "uuid": "^9.0.0" }, "nyc": { "reporter": [ "lcov" ] }, "engines": { "node": ">=12.22.0" }, "mocha": { "exit": true, "timeout": 8000, "recursive": true, "require": "ts-node/register" } }Any other comments can go here
I'm using NodeNext to leverage the new node flag
--transform-types.The text was updated successfully, but these errors were encountered: