Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R1CS instance does not match the definition #69

Open
ishwarbb opened this issue May 7, 2024 · 1 comment
Open

R1CS instance does not match the definition #69

ishwarbb opened this issue May 7, 2024 · 1 comment

Comments

@ishwarbb
Copy link

ishwarbb commented May 7, 2024

The R1CS instance example used in cubic.rs is not an R1CS instance according to https://eprint.iacr.org/2020/1069.pdf Theorem 19 . Although it's still a valid constraint system, it's just more inefficient

image

We need total constraints to be No.of Multiplication gates + 1. The last constraint handles all additions and Basically the last two constraints can be combined into one addition constraint.

@srinathsetty
Copy link
Contributor

Thanks for the note! Yes, cubic.rs is just an example. Please feel free to submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants