Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if find_last can find anything #4561

Merged
merged 12 commits into from
Apr 9, 2024
Merged

Check if find_last can find anything #4561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6ac8d03
Check if `find_last` can find anything
AlexGuteniev Apr 4, 2024
f550ee6
format
AlexGuteniev Apr 4, 2024
ee9f96f
more coverage
AlexGuteniev Apr 4, 2024
89a3628
more coverage
AlexGuteniev Apr 4, 2024
b8ceedd
Test with vectorization enabled/disabled.
StephanTLavavej Apr 6, 2024
4586449
Add extra `ValueType{...}` to match previous test.
StephanTLavavej Apr 6, 2024
69448d5
`16` => `17` to match previous test.
StephanTLavavej Apr 6, 2024
4818067
Consistently test the range overload.
StephanTLavavej Apr 6, 2024
59c3fcd
Compare against `.begin()` and `.end()` for consistency.
StephanTLavavej Apr 6, 2024
fecfb2c
Pre-existing: Add missing `count()` coverage, reorder to `find()` the…
StephanTLavavej Apr 6, 2024
998f929
Style: Adjust newlines.
StephanTLavavej Apr 6, 2024
609ee42
Add more test coverage.
StephanTLavavej Apr 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion stl/inc/algorithm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2972,7 +2972,12 @@ namespace ranges {
if constexpr (is_same_v<_Pj, identity> && _Vector_alg_in_find_is_safe<_It, _Ty>
&& sized_sentinel_for<_Se, _It>) {
if (!_STD is_constant_evaluated()) {
const auto _Count = _Last - _First;
const auto _Count = _Last - _First;

if (!_STD _Could_compare_equal_to_value_type<_It>(_Value)) {
return {_First + _Count, _First + _Count};
}

const auto _First_ptr = _STD _To_address(_First);
const auto _Last_ptr = _First_ptr + _Count;

Expand Down
3 changes: 3 additions & 0 deletions tests/std/tests/Dev11_0316853_find_memchr_optimization/env.lst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,6 @@
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception

RUNALL_INCLUDE ..\usual_matrix.lst
RUNALL_CROSSLIST
* PM_CL=""
* PM_CL="/D_USE_STD_VECTOR_ALGORITHMS=0"
Loading