Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] [python-package] more errors from scikit-learn rearranging estimator tags #6717

Closed
jameslamb opened this issue Nov 12, 2024 · 1 comment · Fixed by #6718
Closed

[ci] [python-package] more errors from scikit-learn rearranging estimator tags #6717

jameslamb opened this issue Nov 12, 2024 · 1 comment · Fixed by #6718

Comments

@jameslamb
Copy link
Collaborator

jameslamb commented Nov 12, 2024

Description

scikit-learn recently merged another change to how estimator tags are handled: scikit-learn/scikit-learn#30149

As a result, the CI job here testing against scikit-learn nightlies is failing like this:

E   AttributeError: 'Tags' object has no attribute '_xfail_checks'

(build link)

Reproducible example

N/A

Environment info

Additional Comments

Relevant other discussions:

@jameslamb jameslamb self-assigned this Nov 12, 2024
@jameslamb jameslamb changed the title [ci] [python-package] error with latest scikit-learn: " AttributeError: 'Tags' object has no attribute '_xfail_checks'" [ci] [python-package] more errors from scikit-learn rearranging estimator tags Nov 12, 2024
@jameslamb
Copy link
Collaborator Author

jameslamb commented Nov 12, 2024

The error reported above during test collection. Fixing it revealed other recent scikit-learn changes we'll have to adapt to.

As a result of scikit-learn/scikit-learn#30122, I see these failures here:

FAILED tests/python_package_test/test_sklearn.py::test_stacking_regressor - ValueError: The estimator LGBMRegressor should be a regressor
FAILED tests/python_package_test/test_sklearn.py::test_stacking_classifier - ValueError: 'final_estimator' parameter should be a classifier. Got LGBMClassifier(n_estimators=3)

(build link)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant