Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate configuration setting #34

Open
algattik opened this issue Mar 22, 2020 · 0 comments
Open

Duplicate configuration setting #34

algattik opened this issue Mar 22, 2020 · 0 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers

Comments

@algattik
Copy link
Contributor

In the Helm chart, configuration values such as aadClientId (and others) are set twice:

In deployment.yaml:

        - name: aadClientId
          value: "{{ .Values.settings.aadClientId }}"

In configmap.yaml:

  aadClientId: "{{ .Values.settings.aadClientId }}"
@eladiw eladiw added the good first issue Good for newcomers label Apr 13, 2020
@AsafMah AsafMah added documentation Improvements or additions to documentation enhancement New feature or request labels May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AsafMah @eladiw @algattik