Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifying WAM errors #280

Merged
merged 5 commits into from
Oct 4, 2024
Merged

Simplifying WAM errors #280

merged 5 commits into from
Oct 4, 2024

Conversation

huzaifa-d
Copy link
Contributor

@huzaifa-d huzaifa-d commented Sep 30, 2024

Summary of the pull request

  1. Authentication issues produce error messages with PII redacted strings which when shown to the user is confusing. This PR simplifies the two most common ones and adds a link for more information for other such errors.
  2. This PR also makes Dev Box instances aware that it's in a saving state. Currently firing a change state event to tell Dev Home the state has changed to 'saving' was occurring without actually updating the Dev Boxes state to saving. Which in turn resulted in a race condition that ended up showing duplicate pinning/unpinning operations on Dev Home.

Validation steps performed

Manual

PR checklist

@huzaifa-d huzaifa-d marked this pull request as ready for review October 3, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants