Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SmallRye: Compatible Certification Request for MicroProfile OpenTracing 2.0 #214

Open
8 tasks done
xstefank opened this issue Dec 10, 2020 · 5 comments
Open
8 tasks done

Comments

@xstefank
Copy link
Member

xstefank commented Dec 10, 2020

  • Organization Name ("Organization") and, if applicable, URL:

    Red Hat

  • Product Name, Version and download URL (if applicable):

    SmallRye OpenTracing 2.0.0-RC1

  • Specification Name, Version and download URL:

    MicroProfile OpenTracing 2.0

  • Public URL of TCK Results Summary:

    https://github.com/smallrye/smallrye-opentracing/actions/runs/412983690

  • Java runtime used to run the implementation:

    Java 8 and 11

  • Summary of the information for the certification environment, operating system, cloud, ...:

    GH Actions - Ubuntu

  • By checking this box I acknowledge that the Organization I represent accepts the terms of the EFTL.

  • By checking this box I attest that all TCK requirements have been met, including any compatibility rules.

@kwsutter
Copy link
Member

The Specification Name and Version item should point at the actual Spec. I would put a reference to the eventual maven repo: https://search.maven.org/artifact/org.eclipse.microprofile.opentracing/microprofile-opentracing-spec/2.0

Same thing for the Compatible Impl. Reference the maven artifact: https://search.maven.org/artifact/io.smallrye/smallrye-opentracing/2.0.0-RC1/jar

@xstefank
Copy link
Member Author

@kwsutter updated.

@Emily-Jiang
Copy link
Member

The Specification Name and Version item should point at the actual Spec. I would put a reference to the eventual maven repo: https://search.maven.org/artifact/org.eclipse.microprofile.opentracing/microprofile-opentracing-spec/2.0

@kwsutter This depends on the purpose of this CCR. If we put the unexisting repo as your specified, people won't be able to click the link to verify. This might have defeated the purpose of this CCR. CCR is not the certification proof from my understanding. It is the evidence to prove we can pass all TCKs so we can release the artificates. With what your suggestions, it is like you want this issue hangs around after the release. I think all links should be clickable. I think the link to the relevant repo release tag is the permanent link and it always works even after the push to maven central happens (e.g. https://github.com/eclipse/microprofile-config/releases/tag/2.0)

Same thing for the Compatible Impl. Reference the maven artifact: https://search.maven.org/artifact/io.smallrye/smallrye-opentracing/2.0.0-RC1/jar

@kwsutter
Copy link
Member

@Emily-Jiang See my response in the other CCR with the same comment: eclipse/microprofile-fault-tolerance#586 (comment)

@dblevins
Copy link
Member

Similar feedback as @kwsutter. See my same comment on this CCR eclipse/microprofile-open-api#459 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants