Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate CPP typesupport #47

Open
wants to merge 3 commits into
base: galactic
Choose a base branch
from
Open

Conversation

pablogs9
Copy link
Member

Signed-off-by: Pablo Garrido pablogs9@gmail.com

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2022

Codecov Report

❗ No coverage uploaded for pull request base (galactic@51c7e2b). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head aacbb1c differs from pull request most recent head 5135b0e. Consider uploading reports for the commit 5135b0e to get more accurate results

@@            Coverage Diff             @@
##             galactic     #47   +/-   ##
==========================================
  Coverage            ?   0.00%           
==========================================
  Files               ?       1           
  Lines               ?       9           
  Branches            ?       2           
==========================================
  Hits                ?       0           
  Misses              ?       9           
  Partials            ?       0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51c7e2b...5135b0e. Read the comment docs.

@pablogs9 pablogs9 changed the base branch from fix/regression_aligment to galactic April 28, 2022 05:48
Signed-off-by: Pablo Garrido <pablogs9@gmail.com>
@pablogs9 pablogs9 requested a review from Acuadros95 May 10, 2022 12:24
@Acuadros95
Copy link
Contributor

This implies modifications on rmw_microxrcedds. Example: https://github.com/micro-ROS/rmw_microxrcedds/blob/galactic/rmw_microxrcedds_c/src/rmw_publisher.c#L26-L27

@k7g03z
Copy link

k7g03z commented Nov 10, 2022

@pablogs9 Can you provide some background why the type support for CPP is being deprecated?

We are looking into Micro-ROS as a microcontroller solution together with rclcpp and found this MR. Can you tell us more?

@pablogs9
Copy link
Member Author

Hello, @k7g03z micro-ROS targets pure C environments in order to be as portable as possible. That's why we do not need this CPP type support (in fact it was developed, but never used). Also we do not officially support RCLCPP because the portability issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants