Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: {teamcards} should display any role defined as course contact #264

Open
7 tasks done
joostelshoff opened this issue Aug 22, 2023 · 4 comments
Open
7 tasks done
Assignees
Labels
feature request New features, enhancements Ready for testing Feature has been implemented and we are waiting for participant to test.

Comments

@joostelshoff
Copy link

Prerequisites

  • I am requesting the new feature to the correct repository.
  • I checked the latest version on GitHub and the README.md documentation to ensure that this functionality does not already exist.
  • I searched to make sure that this feature has not already been requested.
  • I have, or I know someone who has, the ability and willingness to test the new feature on a Moodle LMS-based site.
  • I agree to submit one feature request per issue ticket (do not submit multiple requests in one issue ticket).
  • I understand that development and support is provided by volunteer(s) and that all final implementation decisions are up TNG Consulting Inc.

Feature Request - The User Story

When adding the {teamcards} tag, this should display all users in a course with a role that has been defined as course contact elsewhere in Moodle. Currently, the code states that {teamcards} will list anyone with roleid = 3 (which is editingteacher). This ignores that organisations would use this role as an archetype for custom roles that are actually teaching and creating content in courses (filter.php line 946).

It would be an improvement if this was in line with the {coursecontacts} card.

Screenshots / Mock-ups

No response

Alterative you have considered

No response

Additional information

No response

Planning on submitting a solution in a pull request (PR)?

No

Code of Conduct

@michael-milette
Copy link
Owner

Hi @joostelshoff ,

Thank you for your suggestion. The {teamcards} tag is meant to be used to display a list of faculty across the whole site, not necessarily just in a course. However, it sounds to me like what you are really looking for is the {coursecontacts}, or have I misunderstood your goal?

Best regards,

Michael

@michael-milette
Copy link
Owner

After reviewing your request agian, I think I get what you are saying. I will give this more thought.

@michael-milette michael-milette self-assigned this Nov 5, 2023
@michael-milette michael-milette added the feature request New features, enhancements label Nov 5, 2023
@michael-milette
Copy link
Owner

Working on it. Coming soon!

@michael-milette
Copy link
Owner

Hi @joostelshoff ,

I just updated the version of FilterCodes here on GitHub. The {teamcards} tag should now work the way you suggestion. If you would be so kind, I would appreciate it if you would give it a try and let me know how it goes.

If everything looks good, I will include the change in the next release of FilterCodes on Moodle.org.

Best regards,

Michael

@michael-milette michael-milette added the Ready for testing Feature has been implemented and we are waiting for participant to test. label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New features, enhancements Ready for testing Feature has been implemented and we are waiting for participant to test.
Projects
None yet
Development

No branches or pull requests

2 participants