Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of requests instead of urlib #21

Open
femtotrader opened this issue Jun 14, 2015 · 1 comment
Open

Use of requests instead of urlib #21

femtotrader opened this issue Jun 14, 2015 · 1 comment
Assignees

Comments

@femtotrader
Copy link

Hi,

You might use requests instead of urllib
https://github.com/mhallsmoore/qsforex/blob/d191aad64102ebfa113357987f59f61f0667a190/execution/execution.py

http://docs.python-requests.org/en/latest/

So you won't have to maintain boilerplate code to support both Python 2 and Python 3

Kind regards

@mhallsmoore
Copy link
Owner

Hi Femtotrader,

Indeed this is a good point. I recently removed some references of urllib in the SAT book. In fact, other parts of QSForex already use requests.

I'll remove urllib for a future release.

Cheers,

Mike.

@mhallsmoore mhallsmoore self-assigned this Jun 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants