Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub action: golangci-lint #116

Closed
ccoVeille opened this issue Apr 18, 2024 · 3 comments
Closed

GitHub action: golangci-lint #116

ccoVeille opened this issue Apr 18, 2024 · 3 comments

Comments

@ccoVeille
Copy link
Contributor

Would you like me to help you in setting up golangci-lint for your project ?

This tool is the one I used to find some errors in #111

I will like to not only set it up, but also add a GitHub action for it.

This is great tool to avoid errors to get added via PR.
@mfridman
Copy link
Owner

Sure. Just make sure make lint and the CI job run the same set of linters.

https://github.com/pressly/goose/blob/d0641b5bfb3bd5d38d95fe7a63d7ddf2d282234d/Makefile#L31-L33

@ccoVeille
Copy link
Contributor Author

Sure, I can add that first, then the CI

ccoVeille added a commit to ccoveille-forks/mfridman-tparse that referenced this issue Apr 22, 2024
@ccoVeille
Install and configure golangci-lint
694615c 
see mfridman#116
@ccoVeille ccoVeille mentioned this issue Apr 22, 2024
Merged
@mfridman
Copy link
Owner

mfridman commented Aug 9, 2024

I believe this has been complete, closing.

@mfridman mfridman closed this as completed Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ccoVeille @mfridman