This repository has been archived by the owner on Feb 9, 2024. It is now read-only.
Refactoring & improving playlist saving #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uire some refactoring.
…ading to subsonic. Also, use Troi Playlists objects instead of lists of recordings or... ick jspf. Let's use JSPF only for reading and writing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finishes the support for resolving playlists and letting the user decide if they should be written to jspf, m3u or subsonic. At the same time it refactors internals and standardizes on the Troi PlaylistElement object for internal playlist representation. Now JSPF is only used for reading/writing playlists. More comments, improved variable naming, less duplication and other tiny bits of cleanup.