fix bug where some requests pass variables = {} instead of variables undefined #714
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm seeing an issue with fastify + mercurius where some GraphQL playgrounds / queries are getting parsed as
variables = {}
instead of the expectedvariables = undefined
Versions:
This is most easily seen when using GraphQL Playground vs Insomnia:
Insomnia:
vs GQL Playground (or Altair)
Notice the variable values are different. There's no difference in fastify implementation, just a difference with clients.
The difference in variables value is causing mercurius to blow up on document not being set inside
buildExecutionContext