Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Backwards-compatible identifier quoting in fully qualified names #2603

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Aug 13, 2024

Follows from #2601


📚 Documentation preview 📚: https://meltano-sdk--2603.org.readthedocs.build/en/2603/

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/backwards-compat-sql-ident-quoting branch from a8fcd81 to a087955 Compare August 13, 2024 19:14
Copy link

codspeed-hq bot commented Aug 13, 2024

CodSpeed Performance Report

Merging #2603 will not alter performance

Comparing edgarrmondragon/refactor/backwards-compat-sql-ident-quoting (a087955) with main (c3c2351)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.61%. Comparing base (c3c2351) to head (a087955).
Report is 120 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2603      +/-   ##
==========================================
+ Coverage   89.57%   89.61%   +0.04%     
==========================================
  Files          58       58              
  Lines        4816     4816              
  Branches      943      944       +1     
==========================================
+ Hits         4314     4316       +2     
+ Misses        350      348       -2     
  Partials      152      152              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

edgarrmondragon added a commit to MeltanoLabs/target-postgres that referenced this pull request Aug 13, 2024
edgarrmondragon added a commit to MeltanoLabs/tap-postgres that referenced this pull request Aug 13, 2024
@edgarrmondragon edgarrmondragon marked this pull request as ready for review August 13, 2024 19:39
@edgarrmondragon edgarrmondragon merged commit 477a5eb into main Aug 13, 2024
34 of 35 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/refactor/backwards-compat-sql-ident-quoting branch August 13, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant