From ce4b9a7fd4b0217d74ce3e94f7445c990417412a Mon Sep 17 00:00:00 2001
From: Dan Norman <buzzcutnorman@gmail.com>
Date: Thu, 17 Aug 2023 09:40:44 -0600
Subject: [PATCH] feat: SQLTap connector instance shared with streams (#1861)

Co-authored-by: Edgar R. M <edgar@meltano.com>
---
 singer_sdk/tap_base.py | 26 ++++++++++++++++++++++++--
 1 file changed, 24 insertions(+), 2 deletions(-)

diff --git a/singer_sdk/tap_base.py b/singer_sdk/tap_base.py
index 08ce6f3ad..8b025a1f8 100644
--- a/singer_sdk/tap_base.py
+++ b/singer_sdk/tap_base.py
@@ -30,6 +30,7 @@
 if t.TYPE_CHECKING:
     from pathlib import PurePath
 
+    from singer_sdk.connectors import SQLConnector
     from singer_sdk.mapper import PluginMapper
     from singer_sdk.streams import SQLStream, Stream
 
@@ -612,6 +613,8 @@ class SQLTap(Tap):
     # Stream class used to initialize new SQL streams from their catalog declarations.
     default_stream_class: type[SQLStream]
 
+    _tap_connector: SQLConnector | None = None
+
     def __init__(self, *args: t.Any, **kwargs: t.Any) -> None:
         """Initialize the SQL tap.
 
@@ -624,6 +627,19 @@ def __init__(self, *args: t.Any, **kwargs: t.Any) -> None:
         self._catalog_dict: dict | None = None
         super().__init__(*args, **kwargs)
 
+    @property
+    def tap_connector(self) -> SQLConnector:
+        """The connector object.
+
+        Returns:
+            The connector object.
+        """
+        if self._tap_connector is None:
+            self._tap_connector = self.default_stream_class.connector_class(
+                dict(self.config),
+            )
+        return self._tap_connector
+
     @property
     def catalog_dict(self) -> dict:
         """Get catalog dictionary.
@@ -637,7 +653,7 @@ def catalog_dict(self) -> dict:
         if self.input_catalog:
             return self.input_catalog.to_dict()
 
-        connector = self.default_stream_class.connector_class(dict(self.config))
+        connector = self.tap_connector
 
         result: dict[str, list[dict]] = {"streams": []}
         result["streams"].extend(connector.discover_catalog_entries())
@@ -653,6 +669,12 @@ def discover_streams(self) -> list[Stream]:
         """
         result: list[Stream] = []
         for catalog_entry in self.catalog_dict["streams"]:
-            result.append(self.default_stream_class(self, catalog_entry))
+            result.append(
+                self.default_stream_class(
+                    tap=self,
+                    catalog_entry=catalog_entry,
+                    connector=self.tap_connector,
+                ),
+            )
 
         return result