-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fail clang-tidy #19
base: develop
Are you sure you want to change the base?
fail clang-tidy #19
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #19 +/- ##
=======================================
Coverage 98.6% 98.6%
=======================================
Files 25 25
Lines 798 798
=======================================
Hits 787 787
Misses 11 11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
MegaLinter status: ⛔ ERRORSee errors details in artifact MegaLinter reports on CI Job page |
597d1ab
to
51df406
Compare
Failure clang-tidy. Signed-off-by: Melg Eight <public.melg8@gmail.com>
Enable upload. Signed-off-by: Melg Eight <public.melg8@gmail.com>
437fffd
to
bcbab70
Compare
@@ -25,7 +25,7 @@ enum class Asn1IntErrc { | |||
kSuccess = 0, // 0 should not represent an error | |||
kAllocationFailure = 1, | |||
kNullPointerFailure = 2, | |||
kConversionFailure = 3, | |||
bad_name = 3, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reported by reviewdog 🐶
invalid case style for enum constant 'bad_name' [readability-identifier-naming]
@@ -25,7 +25,7 @@ enum class Asn1IntErrc { | |||
kSuccess = 0, // 0 should not represent an error | |||
kAllocationFailure = 1, | |||
kNullPointerFailure = 2, | |||
kConversionFailure = 3, | |||
bad_name = 3, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[diff] reported by reviewdog 🐶
bad_name = 3, | |
bad_name = 3, |
Download the artifacts for this pull request: |
Failure clang-tidy. Signed-off-by: Melg Eight <public.melg8@gmail.com>
bcbab70
to
72814c3
Compare
@@ -2,4 +2,4 @@ | |||
// | |||
// SPDX-License-Identifier: MIT | |||
|
|||
#include <asn_1_int_errc.h> | |||
#include <asn_1_int.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reported by reviewdog 🐶
sources/example_glassy/library/sources/asn_1_int_errc.cpp should include its header file sources/example_glassy/library/sources/asn_1_int_errc.h [build/include]
01a8717
to
aeefe75
Compare
b8743c8
to
7bfec58
Compare
83581ef
to
bef3ca6
Compare
298b76e
to
7f3931a
Compare
Failure clang-tidy.