Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail clang-tidy #19

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fail clang-tidy #19

wants to merge 3 commits into from

Conversation

melg8
Copy link
Owner

@melg8 melg8 commented May 18, 2022

Failure clang-tidy.

@codecov-commenter
Copy link

codecov-commenter commented May 18, 2022

Codecov Report

Merging #19 (1062a23) into develop (9ee12c1) will not change coverage.
The diff coverage is n/a.

❗ Current head 1062a23 differs from pull request most recent head 437fffd. Consider uploading reports for the commit 437fffd to get more accurate results

@@           Coverage Diff           @@
##           develop     #19   +/-   ##
=======================================
  Coverage     98.6%   98.6%           
=======================================
  Files           25      25           
  Lines          798     798           
=======================================
  Hits           787     787           
  Misses          11      11           
Flag Coverage Δ
clang_unit_tests 98.3% <ø> (ø)
gcc_unit_tests 100.0% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/example_glassy/library/sources/asn_1_int_errc.h 94.1% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ee12c1...437fffd. Read the comment docs.

@github-actions
Copy link

github-actions bot commented May 18, 2022

MegaLinter status: ⛔ ERROR

See errors details in artifact MegaLinter reports on CI Job page

@melg8 melg8 force-pushed the develop branch 4 times, most recently from 597d1ab to 51df406 Compare May 24, 2022 03:58
melg8 added 2 commits May 27, 2022 14:52
Failure clang-tidy.

Signed-off-by: Melg Eight <public.melg8@gmail.com>
Enable upload.

Signed-off-by: Melg Eight <public.melg8@gmail.com>
@@ -25,7 +25,7 @@ enum class Asn1IntErrc {
kSuccess = 0, // 0 should not represent an error
kAllocationFailure = 1,
kNullPointerFailure = 2,
kConversionFailure = 3,
bad_name = 3,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reported by reviewdog 🐶
invalid case style for enum constant 'bad_name' [readability-identifier-naming]

@@ -25,7 +25,7 @@ enum class Asn1IntErrc {
kSuccess = 0, // 0 should not represent an error
kAllocationFailure = 1,
kNullPointerFailure = 2,
kConversionFailure = 3,
bad_name = 3,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[diff] reported by reviewdog 🐶

Suggested change
bad_name = 3,
bad_name = 3,

@github-actions
Copy link

github-actions bot commented May 27, 2022

Download the artifacts for this pull request:

Failure clang-tidy.

Signed-off-by: Melg Eight <public.melg8@gmail.com>
@@ -2,4 +2,4 @@
//
// SPDX-License-Identifier: MIT

#include <asn_1_int_errc.h>
#include <asn_1_int.h>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reported by reviewdog 🐶
sources/example_glassy/library/sources/asn_1_int_errc.cpp should include its header file sources/example_glassy/library/sources/asn_1_int_errc.h [build/include]

@melg8 melg8 force-pushed the develop branch 3 times, most recently from 01a8717 to aeefe75 Compare December 12, 2022 07:02
@melg8 melg8 force-pushed the develop branch 8 times, most recently from b8743c8 to 7bfec58 Compare January 6, 2023 06:37
@melg8 melg8 force-pushed the develop branch 4 times, most recently from 83581ef to bef3ca6 Compare January 14, 2023 17:08
@melg8 melg8 force-pushed the develop branch 30 times, most recently from 298b76e to 7f3931a Compare January 21, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants