Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action Feedback: Create particle effect for action feedback #275

Open
bastianilso opened this issue Sep 4, 2023 · 11 comments
Open

Action Feedback: Create particle effect for action feedback #275

bastianilso opened this issue Sep 4, 2023 · 11 comments
Assignees

Comments

@bastianilso
Copy link

It would be nice if the checkmarks, in addition to color, scale, transparency changes also change in terms of particle emission.

PerformanceManager sends a value between 0 and 1. This value needs to be translated into a number of particles, where 0 = no particles and 1 = all particles. The particles may also adopt their color based on the color of the Mole.

@hendrikknoche
Copy link

then you might want to invert the current colour feedback scheme (dark worse, light better performance) as the particles might otherwise vanish with respect to the background. What do you think?

@bastianilso
Copy link
Author

The color scheme was already inverted: it is now
light-desaturated-transparent=worse,
dark-saturated-opaque=better.

@hendrikknoche
Copy link

:-D I missed that when trying it ... or haven't seen it yet. Great!

@ElMarchand
Copy link
Collaborator

ElMarchand commented Sep 13, 2023

Particles tests

“Pop” effect

Bastian’s request
*Bastians edit: (Bastian's animation omitted for now, we cant put it online yet as its part of an anoymized submission.)

Result 1 - basic effect, needs to be enhanced, it lacks “life” in my opinion
record1pop

Result 2 - Added size change over lifetime to have a better “feel” of the fade effect, made the dashes wider but there are less of them now
result2

Result 3 - Minimal changes, just added some more fade to it
result3

I was not sure of the colours I needed to use but if there's something you want to try/check if it's possible with the particle system, I can do it.

@hendrikknoche
Copy link

very nice to see. Could you add the mole to the picture? without it's disappearance the experience is very isolated and removed from context.

@ElMarchand
Copy link
Collaborator

I can try but I made these in an isolated project and I already tried to import the mole model (it crashed unity), I'll try again and send the results.

@ElMarchand
Copy link
Collaborator

3withmole
Done !

@hendrikknoche
Copy link

hmm, the moles don't look like the ones we have in the current version.
image

@hendrikknoche
Copy link

the outer circle of the mole should disappear the mole body changes colour (either during or after the particles are finished)

@bastianilso
Copy link
Author

bastianilso commented Sep 13, 2023

@ElMarchand nice progress! Unfortunately I had to omit the full animation from your post for now, since its part of an anonymous submission for the time being (sorry).

Feedback:
I think this is a good starting point, well done. I know this can be difficult to see from the quick animation I sent, but the direction of the lines in your animation is not the same as the direction of the lines in the provided animation. Here is a close-up of what is happening (im slowly scrubbing the animation forwards and backwards):
Screencast from 2023-09-13 17-05-15.webm

  1. The lines are vertical and radially instantiated from the center of the mole. What I mean is, they face "away" from the mole (90 degrees) instead of following the mole's outline.
  2. The lines increase and decrease in line length - not sure how easy that is to replicate, but you could consider animating the scale along the line length.

As for your question about color, the color should follow the mole's (green) feedback color. (the exact hexadecimal color depends on how fast players hit the mole).

Looking forward to see the next iteration!

@ElMarchand
Copy link
Collaborator

ElMarchand commented Nov 21, 2023

I have this effect currently implemented on a regular mole. (the gif is slower than the actual effect)
Particle1
It should be working but for some reason, even if I don't use the particle in the Mainscene, every animation disappear and all moles are white, even if the game still plays.
image

I don't know how I did this but I will try to revert and remake the particle effect to see if it comes from the way I made it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants