Basic CAN Transport Interface for python-can #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust Transport Interface API to asynchronous/synchronous implementation.
Add performance tests for transmission queue.
…interface # Conflicts: # uds/transport_interface/transmission_queue.py
Notifier + Listener example :D
Simplify the task and get rid of unnecessary implementation.
…hon-can-transport-interface
…hon-can-transport-interface
Rework Transport Interface API according to current needs.
minor upgrade for static code analysis
Rework abstract classes and get rid of LGTM errors suppression (no longer in use).
Change dictionaries used by addressing information classes to always contain every attribute - to make it compatible and easily replaced by other addressing information types.
Adjust code and tests for CanSegmenter class. Move to pytest>=7.0.0
Implemented sync send_packet method in transport_interface, but that causes problems with async_implementation (both Async and Sync Queue don't like each other). I need to either switch to only async methods or find a way to have both queues types.
…ving packets - examples - remade Abstract Transport Interface - raw code with TODOs for python-can Transport Interface
Make n_ar and n_as measurements
Add tests for python-can transport interface with Kvaser.
- add timeout tests (sort of performance test on receive_packet method) - update CI file so only software tests are automatically executed (no system tests in cloud testing)
add system tests for transport interface + figure out notifiers problem
Figured out that timeout tests causes problems, still trying to figure out the root cause.
Update system tests. TODO: refactor code and add some test. Seems like we have got it and soon task would be clsoed.
Final version of system tests: - testing scope cover - procedures provided
Adjust python-can transport interface implementation to pass all test cases (both software and system). Add unit tests to reach 100% branch coverage.
Codecov Report
@@ Coverage Diff @@
## main #229 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 42 39 -3
Lines 2493 2434 -59
=========================================
- Hits 2493 2434 -59
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Fix for static code analysis
mdabrowski1990
changed the title
Add comments and clean examples code.
Update of use of 'SCRIPT_LOCATION' variable in every test script.
mdabrowski1990
commented
Oct 19, 2023
minor formatting adjustment for consitency reasons
Update actions
mdabrowski1990
commented
Oct 20, 2023
tests/system_tests/transport_interface/can_transport_interface/test_python_can.py
Outdated
Show resolved
Hide resolved
mdabrowski1990
commented
Oct 20, 2023
tests/system_tests/transport_interface/can_transport_interface/test_python_can.py
Outdated
Show resolved
Hide resolved
Fix a few things during self-reviewing the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#22
How Has This Been Tested?
Process
I know the process and did my best to follow it