Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport Interface configuration for python-can #73

Closed
mdabrowski1990 opened this issue Sep 7, 2021 · 0 comments · Fixed by #166
Closed

Transport Interface configuration for python-can #73

mdabrowski1990 opened this issue Sep 7, 2021 · 0 comments · Fixed by #166
Assignees
Labels
CAN Related to CAN specific implementation implementation Changes to code

Comments

@mdabrowski1990
Copy link
Owner

mdabrowski1990 commented Sep 7, 2021

Requires

#48
#143

Description

As a user, I would like to have efficient way of configuring Transport Interface with python-can bus, so I do not repeat parameter that are already configured for the CAN bus.
As a user, I would like to have possibility to set all CAN specific UDS parameters, so I could consciously configure my CAN Transport Interface.

Mandatory UDS parameters to configure:

  • CAN addressing information (addressing format, target address, source address, address extension and CAN ID) for physical and functional addressing
    CAN Communication model

Optional UDS paramaters to configure:

  • CAN DLC of outcoming frames
    DLC
  • CAN Frame Data Optimization
  • Block Size used in Flow Control
  • Separation Time minimum used in Flow Control
  • timing (and timeout) values - chapter 9.8 in ISO 15765-2
    • N_As
      • timeout = 1000 ms
    • N_Ar
      • timeout = 1000 ms
    • N_Bs
      • timeout = 1000 ms
    • N_Br
      • performance N_Br + N_Ar < 0.9N_Bs timeout
    • N_Cs
      • performance N_Cs + N_As < 0.9N_Cr timeout
    • N_Cr
      • timeout = 1000 ms

Test Strategy

Unit Tests:

  • 100% code coverage

Acceptance Criteria

  • All described parameters can be configured (either directly or via python-can Bus) in Transport Interface for python-can.
  • All described parameters values are accessable for reading.
@mdabrowski1990 mdabrowski1990 added the implementation Changes to code label Sep 7, 2021
@mdabrowski1990 mdabrowski1990 added CAN Related to CAN specific implementation documentation Improvements or additions to documentation labels Sep 7, 2021
@mdabrowski1990 mdabrowski1990 changed the title [refine] Transport Interface configuration for python-can Transport Interface configuration for python-can Sep 8, 2021
@mdabrowski1990 mdabrowski1990 changed the title Transport Interface configuration for python-can [refine] Transport Interface configuration for python-can Sep 8, 2021
@mdabrowski1990 mdabrowski1990 changed the title [refine] Transport Interface configuration for python-can Transport Interface configuration for python-can Sep 9, 2021
@mdabrowski1990 mdabrowski1990 changed the title Transport Interface configuration for python-can [refine] Transport Interface configuration for python-can Dec 6, 2021
@mdabrowski1990 mdabrowski1990 removed the documentation Improvements or additions to documentation label Dec 6, 2021
@mdabrowski1990 mdabrowski1990 changed the title [refine] Transport Interface configuration for python-can Transport Interface configuration for python-can Dec 7, 2021
@mdabrowski1990 mdabrowski1990 self-assigned this Jan 8, 2022
@mdabrowski1990 mdabrowski1990 linked a pull request Jan 29, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CAN Related to CAN specific implementation implementation Changes to code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant