Different ply returned by same position

[mcostalba]

As test case, chose the position after 1. e4

q = {'stm': 'balck', 'sub-fen': 'rnbqkbnr/pppppppp/8/8/4P3/8/PPPP1PPP/RNBQKBNR'}
s = {'sequence': [{'white-move': 'e4'}, {'stm': 'balck', 'sub-fen': 'rnbqkbnr/pppppppp/8/8/4P3/8/PPPP1PPP/RNBQKBNR'}]}

m1 = p.scout(q)['matches']
m2 = p.scout(s)['matches']

print(m1[0])  #   {u'ofs': 666, u'ply': [1]}
print(m2[0])  #   {u'ofs': 666, u'ply': [1, 2]}

We have wrong m2[0] because it should be ply: [1], considering that position is the same, and anyhow the sub-fen is matched at ply 1 not at 2.

The error arises because move_rule is not reset after a single condition matches, but only at the end of the game. Moreover, even if we correct the reset, we would end up with repeated plies in matches output, something like:

{u'ofs': 666, u'ply': [1, 1]}

So we would need to add additional logic to remove duplicates before to output the result.

[gbtami]

Created correct move_rule logic patch as pull request #42 to fix this.
After applied patch this test case is no more a sequence because first and second condition are both satisfied on ply=1.

[gbtami]

Updated the patch to current master and fixed it to pass all unit test also.

[gbtami]

@mcostalba can I do anything else to let you apply pull request #42 ? I think this is the correct way to really fix issue #33 also.