Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on first run when attempting to set up credentials #31

Open
bww opened this issue Nov 12, 2020 · 3 comments
Open

Crash on first run when attempting to set up credentials #31

bww opened this issue Nov 12, 2020 · 3 comments

Comments

@bww
Copy link

bww commented Nov 12, 2020

It's not possible to get past the "Identification" screen, I believe due to the fact that there is no keyring, although I'm not completely sure:

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: NoResult', shell/src/secret.rs:8:55
Linux XXX 5.8.16-2-MANJARO #1 SMP PREEMPT Mon Oct 19 11:33:03 UTC 2020 x86_64 GNU/Linux

I'm using KDE, fwiw.

@bww bww changed the title Crash on first run when attempting to setup credentials Crash on first run when attempting to set up credentials Nov 12, 2020
@matze
Copy link
Owner

matze commented Nov 13, 2020

Thanks for the report, I ignored that issue for the Windows use case but yeah, looks like I need a more general cross-platform solution.

@bww
Copy link
Author

bww commented Feb 14, 2021

Perhaps of interest: while using Secret Service for a side project, I found that using get_any_collection (instead of get_default_collection) works correctly with KWallet. At least insofar as I can successfully store and retrieve records from some unspecified collection.

According to the docs this function tries the default collection first, then some others in a sensible order. So in cases where the default collection works the behavior shouldn't change. You might be able to get way with just swapping that out.

@matze
Copy link
Owner

matze commented Feb 14, 2021

Thanks for the hint, I changed that. But I will keep this issue open because all the unwrap()s should better be replaced by proper error handling. Although I am not sure what to do if we cannot store anything at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants