Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylelint's color-hex-case option is handled incorrectly #321

Open
vvs opened this issue Aug 29, 2017 · 1 comment
Open

Stylelint's color-hex-case option is handled incorrectly #321

vvs opened this issue Aug 29, 2017 · 1 comment

Comments

@vvs
Copy link

vvs commented Aug 29, 2017

As far as I can tell, stylefmt looks up the color-hex-case and then uses the result to format not only the HEX cases, but other cases, like rgba and even plain colors.

So, if color-hex-case is set to "upper", then we end up with:

color: #AABBCC; // this one is correct
color: WHITE; // this one is incorrect, it should not be changed
color: RGBA(0,0,0,0); // this one is incorrect, it should not be changed

As a result, stylelint complains after applying stylefmt (whith color-hex-code set to 'upper'):

Expected "RGBA" to be "rgba"   function-name-case

Please consider removing uppercase/lowercase conversions for non-hex colors, since color-hex-case is only for the hex colors

@oshalygin
Copy link

ditto here, anyone already working on this? I dont mind submitting a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants