Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When <head> present in template, content for placeholders like %cayo.css% and %cayo.head% aren't in correct position #131

Open
matthew-ia opened this issue May 8, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@matthew-ia
Copy link
Owner

They all get sucked into <head> for some reason. Except %cayo.title% which for some reason actually gets kicked out.

I think JSDOM and/or Vite is doing things to the markup, and to really fix it might be worth manipulating the template markup without using JSDOM or similar, so I know for a fact the HTML structure is only modified by my code.

Initially, I was going to see if I could use acorn to parse the HTML and modify it. There's probably something still to that, or Rich Harris' magic-string

Luckily, most of the time, if you have a you want <link> and <script> elements in there, but not always. The primary use case is actually to use without or , so I'll have to come back to this.


(Latest relevant commit: 6dadd99)

@matthew-ia matthew-ia added the bug Something isn't working label May 8, 2023
@matthew-ia matthew-ia modified the milestone: Next May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant