Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown images not displaying #7158

Closed
theme1256 opened this issue Feb 23, 2023 · 13 comments
Closed

Markdown images not displaying #7158

theme1256 opened this issue Feb 23, 2023 · 13 comments
Labels
Bug Report/Open Bug report/issue

Comments

@theme1256
Copy link

Summary

Images sendt as markdown do not display anything in the mobile app.
Originally reported here: mattermost-plugin-memes#issue41

Environment Information

  • Device Name: Sony xperia 5 III
  • OS Version: Android 13
  • Mattermost App Version: 2.1.0
  • Mattermost Server Version: 7.5.2

Steps to reproduce

Send an image (jpg/png) using markdown eg.

![kitten](http://placekitten.com/200/300)

Expected behavior

The image should be displayed.
Currently it works fine for gif's, but normal images do not.

Observed behavior (that appears unintentional)

The image does not appear in app.

Possible fixes

I tried sending the image as an attatchment instead, which worked for an uploaded file, but not for a url-linked image.

@enahum
Copy link
Contributor

enahum commented Feb 24, 2023

@Willyfrog can you please open a ticket for the server as the example above does not add any metadata to the post.

@Willyfrog
Copy link
Contributor

Am I doing something wrong? I get the image to display with the steps above in community server.

IMG_2B5D1EBB3A91-1

@theme1256
Copy link
Author

I'm using a self-hosted server.

@enahum
Copy link
Contributor

enahum commented Feb 24, 2023

@Willyfrog i did test in localhost and got the post without metadata, not sure if it is related to the image proxy or something

@amyblais
Copy link
Member

Opened https://mattermost.atlassian.net/browse/MM-50827.

@amyblais amyblais added the Bug Report/Open Bug report/issue label Feb 24, 2023
@streamer45
Copy link
Contributor

@theme1256 From what I can see, the issue you are reporting may be happening when accessing Mattermost from a different URL than the one configured in ServiceSettings.SiteURL. Could you confirm whether this is the case?

Also, I am not sure how different image types would affect this, assuming they are all posted the same way (i.e. using markdown). Do you have an example of an image that works under the same conditions?

@theme1256
Copy link
Author

The images don't show, no matter the domain. I have three domains connected to the server and it doesn't work on either domain.
It also doesn't work for external images. In my original post I linked to an external image, but images generated from the meme-plugin on the server also don't work. That's what I was originally trying to fix.

I've only tried sending jpg's and gif's, and gif's work.
I tried rewriting the meme-plugin to send the generated images as attatchments, but that gives the same results.

@streamer45
Copy link
Contributor

@theme1256 Alright thanks, I'll try with the plugin then. To confirm, these images are working fine when connecting from web or desktop through the same domain but fail to display on mobile only.

@theme1256
Copy link
Author

Yes, fine through web and desktop-app.
And, fine regardless of domain.

@timur-g
Copy link

timur-g commented Apr 21, 2023

I am not sure if this is the same, but I do not see images in Android app 2.3.0, nor I can download them.
Images are png, from screenshot pasted to MM.

Screenshot_20230421-202014350 (1)

@timur-g
Copy link

timur-g commented Jul 12, 2023

@streamer45 I hope this is not unpolite to call you, but since you referenced this in a PR:
I still have my problem above with app v 2.5.1 - but I do not know for sure that is the same issue as for others.

@amyblais
Copy link
Member

The PR fix attached to this issue is scheduled for an upcoming server release v8.0.

@theme1256
Copy link
Author

I just updated my server to 8.0.1 (newest) and I'm still having this issue.
My android app is version 2.6.0 (newest, from july 12).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report/Open Bug report/issue
Projects
None yet
Development

No branches or pull requests

6 participants