Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional metadata options, text rotation, support for Opentype fonts #57

Open
bladerail opened this issue Mar 24, 2022 · 1 comment
Open

Comments

@bladerail
Copy link

bladerail commented Mar 24, 2022

Hi, I've been experimenting in a local fork and added support for additional metadata options in the yaml files, namely horizontal and vertical alignment, outlineWidth, outlineColor. These already had the core features present, so it was relatively simple to add in the yaml options.

I wanted to rotate text for the change-my-mind meme template, so I experimented with using the fogleman/gg library instead of the current image library. I managed to do it and thus the metadata can now accept text slots with a rotation value in degrees.

Lastly, I modified the font support to accept OTF fonts as well.

I'm mentioning all these as I understand that there is a Contribution checklist. These are features that do not yet have a ticket and they are definitely changes of more than 20 lines of code, so I was hoping that this could become the ticket.

@hanzei hanzei added the Triage label Mar 27, 2022
@catalintomai
Copy link

Hi @bladerail , are you open to submit a PR for the changes you are proposing? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants