-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generated memes do not appear in iOS app #41
Comments
Do you see any errors in the server logs? |
Nope, I haven't got anything, unless there is a config to change to see |
I'm seeing the same problem on Android Mattermost. Memes with standard text appear fine, but if there's custom text it does not show any meme at all. Nothing in the logs unless you use a single quote in the text, then logs say "Unterminated single-quoted string" Works perfectly on desktop and web. Edit: memes v1.4.0 |
Seeing the same problem. Memes show up in Web and in Desktop Client, but not in IOS (stable and beta) and Android clients.. |
Here too… |
Same here. memes v1.4.0 compiled on my machine. Server is 5.38.1, mobile is v1.46.
|
Some more troubleshooting informations: when querying the Mattermost API from my instance, the Community.mattermost.com API response{
"id": "REDACTED",
"create_at": 1633522416109,
"update_at": 1633525971148,
"edit_at": 1633525971148,
"delete_at": 0,
"is_pinned": false,
"user_id": "REDACTED",
"channel_id": "REDACTED",
"root_id": "",
"original_id": "",
"message": "![ancient-aliens](https://community.mattermost.com/plugins/memes/templates/ancient-aliens.jpg?text=salut-2)",
"type": "",
"props": {
"override_icon_url": ""
},
"hashtags": "",
"pending_post_id": "",
"reply_count": 0,
"last_reply_at": 0,
"participants": null,
"metadata": {
"images": {
"https://community.mattermost.com/plugins/memes/templates/ancient-aliens.jpg?text=salut-2": {
"width": 500,
"height": 436,
"format": "jpeg",
"frame_count": 0
}
}
}
}
|
@SHAZM Maybe you can chime here as this a mobile issue? |
I'll have a look and see if I can find what the issue is |
Hi @SHAZM, have you any clues about the cause of this issue? I can confirm it still happens on Mattermost v6.4.0 and mobile v1.49.0. |
I've done a bit of digging and there isn't really anything on the mobile side that's preventing the images from being shown; I think there's likely something in the generator; combinations of the images / texts or formatting it doesn't like. @nathanaelhoun, @hanzei, @moschlar, @Twilek-de, @kevinbosman, @hmenzagh - could you give me the commands you run; i.e.
I'll try digging into the plugin repo; I have a sneaky suspicion that some image formats might not actually be supported that are coming back from the generator, and the generator also fails for some specific uses of text / memes (#48) |
Hi @SHAZM, thanks for digging into this!
Hope it helps! |
This bug exists on both iOS and Android. |
This bug exists now for two years? |
I think I've found the issue... And it's a stupid one... tl:dr;The mobile-app does not support markdown images! The full storyAfter a somewhat short debugging session I discovered that this plugin is sending the images as markdown. |
Possible fix for issue mattermost-community#41. Changing from markdown image to image-attatchment
Sorry, anyone try this? Is issue fixed? |
Everything is in the title, just did a fresh install (Mattermost &
mattermost-plugin-memes
) works like a charm on desktop & web, but I get blank posts from the mobile version.The text was updated successfully, but these errors were encountered: