feat(api)!: Remove base64 expectation for messages in the API #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
==========================================
- Coverage 90.55% 90.35% -0.21%
==========================================
Files 34 34
Lines 1906 1907 +1
==========================================
- Hits 1726 1723 -3
- Misses 180 184 +4 ☔ View full report in Codecov by Sentry. |
poljar
requested changes
Sep 5, 2024
There was a problem hiding this comment.
Looks mostly good, but this needs a bit of a different commit message, please take a look at our contributing guide: https://github.com/matrix-org/vodozemac/blob/main/CONTRIBUTING.md#writing-changelog-entries.
Part of it are breaking changes, so make sure to mark them as such using the appropriate git trailer or a !in the appropriate place on the first line of the commit message.
Signed-off-by: Mathieu Velten <mathieu@velten.xyz>
MatMaul
changed the title
poljar
approved these changes
Sep 5, 2024
|
I tweaked the commit message a bit more, it was a bit terse for the changelog, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the other primitives are dealing directly with bytes I believe so this PR aligns to that.
Signed-off-by: Mathieu Velten mathieu@velten.xyz