-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add metric reaggregation and processed metric formula metadata for API consumers #22335
Draft
diosmosis
wants to merge
64
commits into
5.x-dev
Choose a base branch
from
processed-metric-formula
base: 5.x-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…returned via the API if showRawMetrics = 1, and implement extra temporary metrics in EvolutionMetric
…studio computed metric formulas
… table instances via construction, and add extra metric metadata to EvolutionMetric
Closed
11 tasks
…a to report metadata
…o context (and are thus unused)
…eRate processed metric so it can be expressed as a formula
diosmosis
force-pushed
the
processed-metric-formula
branch
from
June 30, 2024 20:56
bf08844
to
f9a72af
Compare
…etrics and add formulas for goal specific processed metrics to report metadata
…omputed to maintain BC, but allow ConversionPageRate to provide an accurate formula when required
…edMetric instances, as those are meant to be added conditionally based on a query parameter. for API consumers this means to get all formulas they will need to use API.getProcessedReport
…a processedMetrics array
diosmosis
force-pushed
the
processed-metric-formula
branch
from
September 18, 2024 03:37
5714739
to
c9d47e3
Compare
…d update some more expected test files
…es in output + update some expected test files
…trics added via DataTable metadata
diosmosis
force-pushed
the
processed-metric-formula
branch
from
September 19, 2024 23:12
82393c7
to
0c76eb1
Compare
…r processed metrics added via DataTable metadata + update expected test files
…edReport behavior to get this metric's metadata
…d name when site is ecommerce enabled
diosmosis
force-pushed
the
processed-metric-formula
branch
from
September 23, 2024 03:32
c34289c
to
09cc47b
Compare
… parser does not support $ in identifiers, and it was only added since that is the format looker studio uses
…pass, and improve error messages in the new processed metric assert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Usage can be seen in this PR: matomo-org/looker-studio-connector#68
TODO
Review