moyo header completed #5746
moyo header completed #5746
Conversation
There was a problem hiding this comment.
Great job on your submission! 🎉 Your code meets most of the task requirements, and the functionality is intact. There are a few minor improvements you could make, such as using a CSS variable for the blue color, removing the duplicate CSS link, and handling uppercase text via CSS instead of directly in HTML. These changes will enhance your code quality and maintainability. Keep up the good work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| <link | ||
| rel="stylesheet" | ||
| href="style.css" | ||
| /> |
There was a problem hiding this comment.
The stylesheet link here is redundant as the same stylesheet is linked again on lines 30-33. Consider removing one of these links to avoid unnecessary duplication.
| <link | ||
| rel="stylesheet" | ||
| href="./style.css" | ||
| /> |
There was a problem hiding this comment.
This stylesheet link is a duplicate of the one on lines 14-17. You should keep only one of these links to prevent redundancy.
DEMO LINK
TEST REPORT LINK
Header height is set in 1 place (for the links)
Content is vertically centered (for any header height)
CSS is used to show all letters in Uppercase (don't type them in HTML)
Logo is an image wrapped with a link
CSS Variable is used for a blue color
Pseudo-element is used for a blue line below the active link
Code follows all the Code Style Rules ❗️