Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #5733

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

renatoveludo
Copy link

@renatoveludo renatoveludo commented Nov 25, 2024

  • DEMO LINK

  • TEST REPORT LINK

  • [] Header height is set in 1 place (for the links)

  • Content is vertically centered (for any header height)

  • CSS is used to show all letters in Uppercase (don't type them in HTML)

  • Logo is an image wrapped with a link

  • CSS Variable is used for a blue color

  • Pseudo-element is used for a blue line below the active link

  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your submission! 🎉 While your code does not fully meet the task requirements, this decision is made to help you move forward with your learning journey. Please review the following key points to improve your code:

  1. Semantic Tags: Ensure to use semantic tags like <ul> and <li> for navigation items instead of <div> for better accessibility and structure.

  2. Logo Link: The href attribute in the logo's anchor tag should link to a webpage, such as the homepage, rather than an image file.

  3. CSS Variables: Define and use a CSS variable for the blue color as specified in the task requirements.

  4. Pseudo-element for Active Link: Correct the implementation of the pseudo-element for the active link to match design specifications, ensuring the border-style is used correctly.

  5. HTML Formatting: Maintain consistent indentation using 2 spaces throughout your HTML file.

  6. CSS Selector: Avoid using the universal selector * due to potential performance impacts.

  7. Class Naming: Use meaningful class names that represent the content rather than styles or tag names.

  8. Link Hover Effect: Ensure the link hover effect aligns with the design specifications.

  9. Missing Files: Verify that all required images are included in the project directory as mentioned in the task description.

Addressing these issues will enhance the functionality and maintainability of your code. Keep up the good work and continue to learn from these experiences! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

<link
rel="preconnect"
href="https://fonts.gstatic.com"
crossorigin="0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'crossorigin' attribute should be set to 'anonymous' or 'use-credentials'. '0' is not a valid value for this attribute.

src/index.html Show resolved Hide resolved
background-color: #00acdc;
transition: background-color 0.3s;
border-radius: 10px;
border-style: 10px solid;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'border-style' property should not have a value like '10px solid'. It should only specify the style of the border, such as 'solid', 'dashed', etc. If you intended to set a border width, use 'border-width' instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants