Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User setting #39

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

User setting #39

wants to merge 17 commits into from

Conversation

jmohr01
Copy link
Contributor

@jmohr01 jmohr01 commented Nov 30, 2020

Seperated out the resource metanetworks_user_setting (previously auth_setting) as the console (UI) specifies them as user settings but API calls them auth settings

mataneine
mataneine requested changes Dec 14, 2020
View reviewed changes
Copy link
Owner

@mataneine mataneine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmohr01 Can you please rename it user_settings instead of user_setting

@jmohr01
Copy link
Contributor Author

jmohr01 commented Dec 14, 2020

Done, updated from user_setting to user_settings

@jmohr01
Copy link
Contributor Author

jmohr01 commented Dec 15, 2020

Both this and device_settings is now parity with master, with their additional resource, so should be able to merge in now.

Jamey Mohr and others added 8 commits December 16, 2020 07:42
#36 enhancement now allows for [] as mapped_subnets without omitting …
d8b18c5 
…it, and creates empty mapped_subnets resource in meta
Fix for OTAC, removed 'triggers' required params when API does not ca…
9f3bf6d 
…ll for it, and rest of code does not refer to it. Issue #48
Fix for OTAC, removed 'triggers' required params when API does not ca…
17784de 
…ll for it, and rest of code does not refer to it. Issue #48
@jmohr01
Merge pull request #3 from mataneine/master
6d510fb 
Bringing to parity
@jmohr01
Merge pull request #4 from jmohr01/device_setting
9640d1f 
Device setting
@jmohr01
Merge pull request #5 from jmohr01/mapped_subnet_fix
f9c1967 
#36 enhancement now allows for [] as mapped_subnets without omitting …
@jmohr01
Merge pull request #6 from jmohr01/otac_fix
a269d69 
Otac fix
@jmohr01
Merge branch 'master' into user_setting
473cdec
@jmohr01 jmohr01 requested a review from mataneine August 18, 2021 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mataneine mataneine Awaiting requested review from mataneine

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmohr01 @mataneine