feat: 젠킨스 to 깃헙액션 #430
Merged
feat: 젠킨스 to 깃헙액션 #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kh0712
reviewed
Jun 23, 2024
| script: | | ||
| aws ecr get-login-password --region ap-northeast-2 | docker login --username AWS --password-stdin 321148231533.dkr.ecr.ap-northeast-2.amazonaws.com | ||
| cd /home/ec2-user/mashup-server/docker/deploy/admin/dev | ||
| sh ./deploy-admin.sh $TAG |
There was a problem hiding this comment.
지금은 없지만, dev 나중에 develop 에 머지되어야지만 develop 으로 태그만들어지는 방식외에도 별도의 브렌치에서 태그 만드는 방식으로 가려면 스크립트에 태그를 추가하려고 넣어줬습니다!
현재는 태그 넣어도 develop 으로만 되기는 합니당~! sh, docer-compose 수정 필요합니다.
prod 는 master 에 머지되어야지만 태그 만들어지는 방식으로만 현상 유지할 것 같아서, 태그 없애놓은 건데 덜 지웠네요! prod 는 다 지워놓을게욧!
hocaron
force-pushed
the
feature/cd-github-action
branch
from
c9b06d5
to
e9c5b7b
Compare
|
@kh0712 리얼 환경 배포는 관리자만 배포할 수 있도록 권한 체크하는 코드 추가해놓았어용! 요것도 같이 체크 부탁드립니다🙇♀️ (저 다시 어드민으로 권한 수정 부탁드립니다ㅎㅎ🥲) https://github.com/mash-up-kr/mashup-server/actions/runs/9631230964/job/26562761086 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 타입
개요
변경사항