Reconsidering handing of black level

[Alex-Vasile]

Currently handling of black levels for the image requires the black level be carrying around and passed to multiple functions, far downstream of the dng to texture conversion.

Option 1: have image_url_to_texture return a float32 texture with the black level already subtracted.

• Pro: simplified pipeline, less textures, no need for extra conversion, much simpler handling of position-dependent black levels (e.g. row/column dependent)
• Con: Certain functions will need to be re-worked since they work on the pixel intensities with the black level included. The increased memory usage of returning float32 textures can be offset by creating them much closer to when they're needed, and doing so one at a time.

The adobe DNG sdk (and likely the open source one) has functionality for querying black level for individual sub-pixels, making that portion of the implementation easier.

Option 2: carry around more information about black level

• Pro: easier to modify into existing code
• Con: Will increase downstream code complexity, will likely increase memory usage (especially for spatially varying black level), and will increase computation time.

Original public discussion started in #38 (comment)

[Alex-Vasile]

Further consideration, I am not sure the black level is currently being handled correctly. prepare_texture, and the code it was based on, ensures that values are above zero after the black level has been re-added:

hdr-plus-swift/burstphoto/texture/texture.metal

Lines 547 to 549 in 8be652f

	// correct exposure
	pixel_value = (pixel_value - black_level)*corr_factor + black_level;
	pixel_value = max(pixel_value, 0.0f);

While this does prevent negative values in the texture returned by this function, it does not set all pixels below the black level to 0.

I was under the impression that pixels with intensities below the black level should be zeroed out. I.e. the above two lines should be replaced by:

pixel_value = max(0.0f, pixel_value - black_level)*corr_factor + black_level;