Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Go to Definition" broken for v1 scripts in 6.4.0 #559

Closed
Lailloken opened this issue Nov 5, 2024 · 2 comments · Fixed by #562
Closed

"Go to Definition" broken for v1 scripts in 6.4.0 #559

Lailloken opened this issue Nov 5, 2024 · 2 comments · Fixed by #562
Assignees
@mark-wiemer
Labels
AHK v1 exclusive to AHK v1 bug something isn't working

Comments

@Lailloken
Copy link

Lailloken commented Nov 5, 2024 •
edited by mark-wiemer
Loading

Description

"Go to Definition" doesn't work anymore for v1 scripts in 6.4.0 and instead shows this:

image

No definition found for '__func_name__'

The parameters of a function are displayed correctly when hovering over it, however:
image

Rolling back to 6.3.0 fixes the issue.
@Lailloken Lailloken added the bug something isn't working label Nov 5, 2024
@mark-wiemer mark-wiemer added this to AHK++ Nov 5, 2024
@mark-wiemer mark-wiemer moved this to Todo in AHK++ Nov 5, 2024
@mark-wiemer mark-wiemer added the AHK v1 exclusive to AHK v1 label Nov 5, 2024
@mark-wiemer
Copy link
Member

Sorry about this, this will be fixed in the next release for sure. Thanks for reporting.

This was referenced Nov 5, 2024
Closed
Closed
@mark-wiemer mark-wiemer pinned this issue Nov 8, 2024
mark-wiemer added a commit that referenced this issue Nov 8, 2024
@mark-wiemer
Fix "Go to Definition" broken for v1 scripts in 6.4.0 #559
699a90d
mark-wiemer added a commit that referenced this issue Nov 8, 2024
@mark-wiemer
Add test for "Go to Definition" broken for v1 scripts in 6.4.0 #559
ab120bc
mark-wiemer added a commit that referenced this issue Nov 8, 2024
@mark-wiemer
Add manual e2e test for "Go to Definition" broken for v1 scripts in 6…
86cf438 
….4.0 #559
@mark-wiemer mark-wiemer mentioned this issue Nov 8, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in AHK++ Nov 8, 2024
@mark-wiemer
Copy link
Member

Fix will be released this weekend, hoping to bundle another fix or two in there, plus I need to run a ton of manual tests every release to make sure I don't introduce new failures... like this one...

Thanks again for your patience, I hope you can see the new tests ensure this won't happen again!

@mark-wiemer mark-wiemer mentioned this issue Nov 9, 2024
Merged
@mark-wiemer mark-wiemer unpinned this issue Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mark-wiemer mark-wiemer

Labels
AHK v1 exclusive to AHK v1 bug something isn't working
Projects
AHK++
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix go to definition for AHK v1, other misc work mark-wiemer-org/ahkpp
2 participants
@mark-wiemer @Lailloken